This repository was archived by the owner on Jul 11, 2023. It is now read-only.
pkg/*: fix data races in PubSub and ticker test #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a data race in PubSub singleton instantiation where the singleton object creation is not protected from concurrent initialization. Fixes a data race in the ticker test where a variable is written/read to/from without protected access from multiple goroutines. Signed-off-by: Shashank Ram <[email protected]>
draychev
reviewed
Sep 22, 2021
| @@ -59,8 +64,8 @@ func Unsub(unsubChan chan interface{}) { | |||
| // Note that spawning the instance is not thread-safe. First call should happen on | |||
| // a single-routine context to avoid races. | |||
| func getPubSubInstance() *pubsub.PubSub { | |||
| if pubSubInstance == nil { | |||
| pubSubOnce.Do(func() { | |||
draychev
approved these changes
Sep 22, 2021
snehachhabria
approved these changes
Sep 22, 2021
snehachhabria
pushed a commit
to snehachhabria/osm
that referenced
this pull request
Oct 14, 2021
Fixes a data race in PubSub singleton instantiation where the singleton object creation is not protected from concurrent initialization. Fixes a data race in the ticker test where a variable is written/read to/from without protected access from multiple goroutines. Signed-off-by: Shashank Ram <[email protected]> Signed-off-by: Sneha Chhabria <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a data race in PubSub singleton instantiation
where the singleton object creation is not protected
from concurrent initialization.
Fixes a data race in the ticker test where a variable
is written/read to/from without protected access from
multiple goroutines.
Testing done:
Verified
go test -race ./pkg/...succeeds with this change. Previouslythe tests would fail on data races in PubSub initialization and ticker test.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no