Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

events: rename AnnouncementType to Kind #4152

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

shashankram
Copy link
Member

Description:
Renames the type to so that it reads better when
used by other pkgs - announcements.Kind vs
announcements.AnnouncementType.

Affected area:

Functional Area
Control Plane [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

Renames the type to so that it reads better when
used by other pkgs - announcements.Kind vs
announcements.AnnouncementType.

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram requested a review from a team as a code owner September 21, 2021 21:44
@codecov-commenter
Copy link

Codecov Report

Merging #4152 (76f939d) into main (d81ba22) will increase coverage by 0.04%.
The diff coverage is 71.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4152      +/-   ##
==========================================
+ Coverage   69.45%   69.49%   +0.04%     
==========================================
  Files         212      212              
  Lines       11429    11429              
==========================================
+ Hits         7938     7943       +5     
+ Misses       3438     3433       -5     
  Partials       53       53              
Flag Coverage Δ
unittests 69.49% <71.15%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/catalog/dispatcher.go 36.66% <0.00%> (ø)
...certificate/providers/vault/certificate_manager.go 63.06% <0.00%> (ø)
pkg/configurator/client.go 84.80% <66.66%> (ø)
pkg/ticker/ticker.go 90.00% <71.42%> (ø)
...icate/providers/certmanager/certificate_manager.go 85.13% <100.00%> (ø)
...ertificate/providers/tresor/certificate_manager.go 83.47% <100.00%> (ø)
pkg/envoy/registry/announcement_handlers.go 80.00% <100.00%> (ø)
pkg/envoy/registry/services.go 95.40% <100.00%> (ø)
pkg/k8s/event_handlers.go 94.44% <100.00%> (ø)
pkg/k8s/events/event_pubsub.go 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81ba22...76f939d. Read the comment docs.

Copy link
Contributor

@draychev draychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

massive!

@shashankram shashankram merged commit a6bbd66 into openservicemesh:main Sep 21, 2021
@shashankram shashankram deleted the announcement branch September 21, 2021 23:47
snehachhabria pushed a commit to snehachhabria/osm that referenced this pull request Oct 14, 2021
Renames the type to so that it reads better when
used by other pkgs - announcements.Kind vs
announcements.AnnouncementType.

Signed-off-by: Shashank Ram <[email protected]>
Signed-off-by: Sneha Chhabria <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants