This repository was archived by the owner on Jul 11, 2023. It is now read-only.
feat(injector): Set probe timeouts based on pod deployment spec #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Creating as draft to make sure that lint passes, because it timeouts on my devbox |
Codecov Report
@@ Coverage Diff @@
## main #4149 +/- ##
==========================================
+ Coverage 69.47% 69.81% +0.34%
==========================================
Files 210 212 +2
Lines 11423 11579 +156
==========================================
+ Hits 7936 8084 +148
- Misses 3434 3442 +8
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
davinci26
force-pushed
the
probeTimeouts
branch
3 times, most recently
from
1397512 to
5376e77
Compare
shashankram
reviewed
Sep 27, 2021
There was a problem hiding this comment.
@davinci26 Thanks for addressing the issue based on our discussion. This change looks good, except that the commit and PR description is misleading (references to idle_timeout). Could you please address this, looks good otherwise.
Fixes openservicemesh#4137 Overall we aim to maintain the following invariance: For all health probes we want the following to be true: All Envoy (implicit or explicit) timeouts >= the timeout specified in the pod deployment spec. Changes: * Remove connect timeouts from all clusters * For health probe clusters we set the route timeout to be equal to the timeout set on the kubernetes pod. This is only applied on HTTP routes since plain tcp routes have infinite timeout. Signed-off-by: Sotiris Nanopoulos <[email protected]>
davinci26
force-pushed
the
probeTimeouts
branch
from
5376e77 to
4406dc5
Compare
|
@shashankram fixed. Thanks for the feedback on this PR offline, highly appreciate it! |
shashankram
approved these changes
Sep 27, 2021
ksubrmnn
approved these changes
Sep 27, 2021
snehachhabria
pushed a commit
to snehachhabria/osm
that referenced
this pull request
Sep 27, 2021
…servicemesh#4149) Fixes openservicemesh#4137 Overall we aim to maintain the following invariance: For all health probes we want the following to be true: All Envoy (implicit or explicit) timeouts >= the timeout specified in the pod deployment spec. Changes: * Remove connect timeouts from all clusters * For health probe clusters we set the route timeout to be equal to the timeout set on the kubernetes pod. This is only applied on HTTP routes since plain tcp routes have infinite timeout. Signed-off-by: Sotiris Nanopoulos <[email protected]>
snehachhabria
pushed a commit
to snehachhabria/osm
that referenced
this pull request
Oct 14, 2021
…servicemesh#4149) Fixes openservicemesh#4137 Overall we aim to maintain the following invariance: For all health probes we want the following to be true: All Envoy (implicit or explicit) timeouts >= the timeout specified in the pod deployment spec. Changes: * Remove connect timeouts from all clusters * For health probe clusters we set the route timeout to be equal to the timeout set on the kubernetes pod. This is only applied on HTTP routes since plain tcp routes have infinite timeout. Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Sneha Chhabria <[email protected]>
allenlsy
pushed a commit
to allenlsy/osm
that referenced
this pull request
Dec 28, 2021
…servicemesh#4149) Fixes openservicemesh#4137 Overall we aim to maintain the following invariance: For all health probes we want the following to be true: All Envoy (implicit or explicit) timeouts >= the timeout specified in the pod deployment spec. Changes: * Remove connect timeouts from all clusters * For health probe clusters we set the route timeout to be equal to the timeout set on the kubernetes pod. This is only applied on HTTP routes since plain tcp routes have infinite timeout. Signed-off-by: Sotiris Nanopoulos <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4137
Overall we aim to maintain the following invariance:
For all health probes we want the following to be true:
All Envoy (implicit or explicit) timeouts >= the timeout specified in
the pod deployment spec.
Changes:
timeout set on the kubernetes pod. This is only applied on HTTP routes
since plain tcp routes have infinite timeout.
Signed-off-by: Sotiris Nanopoulos [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?