This repository was archived by the owner on Jul 11, 2023. It is now read-only.
envoy/rds: disable default timeout for route to clusters #4127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled the default 15s timeout for routes to clusters because this results in connections being reset when the requests take longer than 15s, such as in the case of large file transfers. Configurable timeouts to access services will be supported in a future release of OSM. Signed-off-by: Shashank Ram <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4127 +/- ##
==========================================
+ Coverage 68.64% 68.78% +0.14%
==========================================
Files 210 210
Lines 11405 11406 +1
==========================================
+ Hits 7829 7846 +17
+ Misses 3524 3508 -16
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Sep 16, 2021
draychev
approved these changes
Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Disabled the default 15s timeout for routes to clusters
because this results in connections being reset when the
requests take longer than 15s, such as in the case of
large file transfers.
Configurable timeouts to access services will be supported
in a future release of OSM.
Testing done:
Tested a large file transfer that takes longer than 15s to
complete and verified it works as expected. Without this
change, the request would timeout at 15s.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no