Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

feat(Windows): Add Windows nightly job #4117

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

davinci26
Copy link

Fixes #3883 Adds a nightly job for Windows tests.

Cluster is installed via AKS-engine on the CNCF subscription.

Signed-off-by: Sotiris Nanopoulos [email protected]

Description:

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

@davinci26 davinci26 requested a review from a team as a code owner September 15, 2021 18:43
@davinci26
Copy link
Author

@shashankram let's talk offline to add the config of the cluster to the repository secrets

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #4117 (2367aaf) into main (46339f4) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4117      +/-   ##
==========================================
- Coverage   69.16%   69.15%   -0.01%     
==========================================
  Files         205      205              
  Lines       11238    11238              
==========================================
- Hits         7773     7772       -1     
- Misses       3413     3414       +1     
  Partials       52       52              
Flag Coverage Δ
unittests 69.15% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/k8s/announcement_handlers.go 72.97% <0.00%> (-5.41%) ⬇️
pkg/certificate/rotor/rotor.go 87.50% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46339f4...2367aaf. Read the comment docs.

@ksubrmnn
Copy link
Contributor

Can you write some documentation for this pipeline in a follow up PR?

How to invoke it, when it runs, etc. Example for openshift pipeline: https://github.com/openservicemesh/osm/blob/main/docs/development_guide/openshift/openshift_nightly.md

Fixes openservicemesh#3883 Adds a nightly job for Windows tests.

Cluster is installed via AKS-engine on the CNCF subscription.

Signed-off-by: Sotiris Nanopoulos <[email protected]>
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davinci26

@ksubrmnn ksubrmnn merged commit c7cfda2 into openservicemesh:main Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing cluster with Windows workers
4 participants