This repository was archived by the owner on Jul 11, 2023. It is now read-only.
add section on attribution to CONTRIBUTING.md #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleN
changed the title
trstringer
approved these changes
Sep 14, 2021
shalier
reviewed
Sep 15, 2021
+ add table of contents + add language identifiers to code blocks + add blank lines around code blocks to make code blocks easier to read (best practice) resolves openservicemesh#1764 Signed-off-by: Michelle Noorali <[email protected]>
michelleN
force-pushed
the
attribution
branch
from
85792d3 to
7f79755
Compare
shalier
approved these changes
Sep 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1764
Signed-off-by: Michelle Noorali [email protected]
Description:
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No