This repository was archived by the owner on Jul 11, 2023. It is now read-only.
tests/framework: optionally retry on pod creation failure #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optionally retries on app pod creation failure when the webhook configuration is not processed by the API server on time. Potential fix for openservicemesh#3973 Signed-off-by: Shashank Ram <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4091 +/- ##
==========================================
- Coverage 69.13% 69.09% -0.05%
==========================================
Files 205 205
Lines 11228 11228
==========================================
- Hits 7763 7758 -5
- Misses 3413 3418 +5
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Sep 9, 2021
ksubrmnn
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Optionally retries on app pod creation failure when the
webhook configuration is not processed by the API server
on time. This is required as a workaround due to potential
delays in the k8s API server to process the updated webhook
configuration after osm-injector patches the webhook.
If this change does not address #3973, it should be reverted.
A large number of test iterations is required to verify this
change in the CI.
Potential fix for #3973.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no