This repository was archived by the owner on Jul 11, 2023. It is now read-only.
envoy/eds: respond with endpoints for all services #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating the EDS response for all upstream endpoints that the downstream proxy is allowed to access, create an EDS response for a service without endpoints as well. This is similar to 78455da which allowed the XDS state machine to converge when there are CDS clusters that use EDS for endpoint discovery. Signed-off-by: Shashank Ram <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4088 +/- ##
==========================================
+ Coverage 69.09% 69.13% +0.04%
==========================================
Files 205 205
Lines 11236 11228 -8
==========================================
Hits 7763 7763
+ Misses 3421 3413 -8
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Sep 9, 2021
nojnhuh
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When generating the EDS response for all upstream
endpoints that the downstream proxy is allowed to
access, create an EDS response for a service without
endpoints as well. This is similar to 78455da which
allowed the XDS state machine to converge when there
are CDS clusters that use EDS for endpoint discovery.
Testing done:
Locally tested the demo.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no