This repository was archived by the owner on Jul 11, 2023. It is now read-only.
envoy: add helper to convert IP CIDR string to XDS object #4082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a helper to conver IP CIDR represented as a string to an XDS CidrRange object, to avoid code duplication. Signed-off-by: Shashank Ram <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4082 +/- ##
==========================================
+ Coverage 69.02% 69.08% +0.05%
==========================================
Files 205 205
Lines 11249 11242 -7
==========================================
+ Hits 7765 7766 +1
+ Misses 3432 3424 -8
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nojnhuh
approved these changes
Sep 8, 2021
snehachhabria
approved these changes
Sep 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a helper to convert IP CIDR represented as a string
to an XDS CidrRange object, to avoid code duplication.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no