Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

test(pkg/certificate/providers): add tests to config file #4015

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

shalier
Copy link
Contributor

@shalier shalier commented Aug 19, 2021

Description:
Adds unit tests to config.go
and resolves #3425

Signed-off-by: Shalier Xia [email protected]

Testing done: N/A

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ x]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

@shalier shalier requested a review from a team as a code owner August 19, 2021 22:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #4015 (332b913) into main (ac3857d) will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4015      +/-   ##
==========================================
+ Coverage   67.51%   68.09%   +0.58%     
==========================================
  Files         204      204              
  Lines       11611    11611              
==========================================
+ Hits         7839     7907      +68     
+ Misses       3721     3653      -68     
  Partials       51       51              
Flag Coverage Δ
unittests 68.09% <ø> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/providers/kube/client.go 64.19% <0.00%> (-0.62%) ⬇️
pkg/crdconversion/crdconversion.go 75.00% <0.00%> (+5.43%) ⬆️
pkg/certificate/providers/config.go 79.89% <0.00%> (+32.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7248ea...332b913. Read the comment docs.

@shalier shalier force-pushed the certConfigTests branch 2 times, most recently from f27af62 to 332b913 Compare August 20, 2021 22:58
@shalier shalier force-pushed the certConfigTests branch 3 times, most recently from f74dcea to 6bb26b3 Compare August 23, 2021 17:47
Adds unit tests to config.go
and resolves openservicemesh#3425

Signed-off-by: Shalier Xia <[email protected]>
@shalier
Copy link
Contributor Author

shalier commented Aug 23, 2021

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2021

Command refresh: success

Pull request refreshed

@mergify mergify bot merged commit fc10617 into openservicemesh:main Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: pkg/certificate/providers/config.go functions
4 participants