Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

add rate limiting functionality #2018

Closed
8 tasks done
michelleN opened this issue Nov 10, 2020 · 1 comment
Closed
8 tasks done

add rate limiting functionality #2018

michelleN opened this issue Nov 10, 2020 · 1 comment
Assignees
@shashankram
Labels
kind/feature-request Feature request kind/research-required Requires further research to make progress priority/P0 P0 priority size/XXL 40 days (2 months)
Milestone
v1.3

Comments

@michelleN
Copy link
Contributor

michelleN commented Nov 10, 2020 •
edited by shashankram
Loading

Please describe the Improvement and/or Feature Request
Design and implement rate limting.

  • Local rate limiting (Phase1)

  • Global rate limiting (Phase 2)

Possible use cases
Users should be able to specify rate limiting policies for traffic.
@michelleN michelleN added kind/research-required Requires further research to make progress improvement / feature request labels Nov 10, 2020
@trstringer trstringer added this to the vFuture milestone Feb 25, 2022
@trstringer trstringer modified the milestones: vFuture, Midterm Mar 28, 2022
@shashankram shashankram self-assigned this May 9, 2022
@shashankram shashankram modified the milestones: vFuture, v1.2 May 9, 2022
@shashankram shashankram added the kind/feature-request Feature request label May 26, 2022
@shashankram shashankram modified the milestones: v1.2, v1.3 May 31, 2022
shashankram added a commit to shashankram/osm that referenced this issue Jun 7, 2022
@shashankram
apis: add local rate limiting to UpstreamTrafficSetting
c21aed3 
Adds the local rate limiting API to the UpstreamTrafficSetting
spec.

Part of openservicemesh#2018

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Jun 7, 2022
Merged
shashankram added a commit to shashankram/osm that referenced this issue Jun 8, 2022
@shashankram
apis: add local rate limiting to UpstreamTrafficSetting
e6ec754 
Adds the local rate limiting API to the UpstreamTrafficSetting
spec.

Part of openservicemesh#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit that referenced this issue Jun 8, 2022
@shashankram
apis: add local rate limiting to UpstreamTrafficSetting (#4796)
1e73ba3 
Adds the local rate limiting API to the UpstreamTrafficSetting
spec.

Part of #2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm that referenced this issue Jun 9, 2022
@shashankram
rate-limiting: add spec to UpstreamTrafficSetting CRD
171a594 
Adds the local rate limiting spec to the UpstreamTrafficSetting
CRD.

Part of openservicemesh#2018

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Jun 9, 2022
Merged
nojnhuh pushed a commit that referenced this issue Jun 9, 2022
@shashankram
rate-limiting: add spec to UpstreamTrafficSetting CRD (#4803)
76ff532 
Adds the local rate limiting spec to the UpstreamTrafficSetting
CRD.

Part of #2018

Signed-off-by: Shashank Ram <[email protected]>
steeling pushed a commit to steeling/osm that referenced this issue Jun 9, 2022
@shashankram @steeling
rate-limiting: add spec to UpstreamTrafficSetting CRD (openservicemes…
20577bd 
…h#4803)

Adds the local rate limiting spec to the UpstreamTrafficSetting
CRD.

Part of openservicemesh#2018

Signed-off-by: Shashank Ram <[email protected]>
Signed-off-by: Sean Teeling <[email protected]>
@shashankram shashankram mentioned this issue Jun 10, 2022
Closed
shashankram added a commit to shashankram/osm that referenced this issue Jun 10, 2022
@shashankram
rate-limiting: plumb config into inbound policies
84d5748 
Plumbs the tcp, virtual_host and per route rate limiting
configs into the inbound traffic policy objects.

Next, they will be mapped to Envoy listener and route
configs.

Part of openservicemesh#2018

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Jun 10, 2022
Merged
shashankram added a commit that referenced this issue Jun 13, 2022
@shashankram
rate-limiting: plumb config into inbound policies (#4807)
7046cf2 
Plumbs the tcp, virtual_host and per route rate limiting
configs into the inbound traffic policy objects.

Next, they will be mapped to Envoy listener and route
configs.

Part of #2018

Signed-off-by: Shashank Ram <[email protected]>
@trstringer trstringer moved this to In Progress in OSM Roadmap (dev) Jun 13, 2022
@shashankram shashankram mentioned this issue Jul 25, 2022
Merged
shashankram added a commit to shashankram/osm-docs that referenced this issue Jul 26, 2022
@shashankram
docs: add global L4 rate limiting demo
c3ed87a 
Adds global L4 rate limiting demo using an external
rate limit service.

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm-docs that referenced this issue Jul 26, 2022
@shashankram
docs: add global L4 rate limiting demo
193edec 
Adds global L4 rate limiting demo using an external
rate limit service.

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Jul 26, 2022
Merged
shashankram added a commit that referenced this issue Jul 27, 2022
@shashankram
rate-limiting: add global L4 rate limiting capability (#4937)
27c574e 
Adds the capability to enable global L4 rate limiting
for traffic to upstream services. The rate limiting
config is applied via the L4 network global rate
limit filter on the upstream listener.

Part of #2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm-docs that referenced this issue Jul 28, 2022
@shashankram
docs: add global L4 rate limiting demo
54fd17c 
Adds global L4 rate limiting demo using an external
rate limit service.

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm-docs that referenced this issue Jul 28, 2022
@shashankram
docs: add global L4 rate limiting demo
feec134 
Adds global L4 rate limiting demo using an external
rate limit service.

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to openservicemesh/osm-docs that referenced this issue Jul 28, 2022
@shashankram
docs: add global L4 rate limiting demo (#425)
5580c1c 
Adds global L4 rate limiting demo using an external
rate limit service.

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Aug 10, 2022
Closed
shashankram added a commit to shashankram/osm-docs that referenced this issue Aug 17, 2022
@shashankram
docs/rate-limit: add global rate limit demo and docs
1dd9966 
- adds a demo guide for global rate limit of HTTP traffic

- updates existing rate limit docs for consistency

- updates API reference guide

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Aug 17, 2022
Merged
shashankram added a commit to shashankram/osm that referenced this issue Aug 17, 2022
@shashankram
rate-limit: add global HTTP rate-limit capability
e52973c 
- Adds global rate limit capability for HTTP traffic

- Updates global rate limit API to allow setting
  the response code for rate limited requests

- Updates envoyproxy/go-control-plane to v0.10.3
  which includes the latest protos for global
  rate limiting. Also updates proto_types.go
  to reflect the usage of the new pkg version.

- Moves rate limit specific code in LDS to its
  own file

- Unit tests for rate limiting changes introduced

Part of openservicemesh#2018

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Aug 17, 2022
Merged
shashankram added a commit to shashankram/osm that referenced this issue Aug 17, 2022
@shashankram
rate-limit: add global HTTP rate-limit capability
6a0ca06 
- Adds global rate limit capability for HTTP traffic

- Updates global rate limit API to allow setting
  the response code for rate limited requests

- Updates envoyproxy/go-control-plane to v0.10.3
  which includes the latest protos for global
  rate limiting. Also updates proto_types.go
  to reflect the usage of the new pkg version.

- Moves rate limit specific code in LDS to its
  own file

- Unit tests for rate limiting changes introduced

Part of openservicemesh#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm-docs that referenced this issue Aug 18, 2022
@shashankram
docs/rate-limit: add global rate limit demo and docs
1233bbf 
- adds a demo guide for global rate limit of HTTP traffic

- updates existing rate limit docs for consistency

- updates API reference guide

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm that referenced this issue Aug 18, 2022
@shashankram
rate-limit: add global HTTP rate-limit capability
b99a0b9 
- Adds global rate limit capability for HTTP traffic

- Updates global rate limit API to allow setting
  the response code for rate limited requests

- Updates envoyproxy/go-control-plane to v0.10.3
  which includes the latest protos for global
  rate limiting. Also updates proto_types.go
  to reflect the usage of the new pkg version.

- Moves rate limit specific code in LDS to its
  own file

- Unit tests for rate limiting changes introduced

Part of openservicemesh#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm-docs that referenced this issue Aug 22, 2022
@shashankram
docs/rate-limit: add global rate limit demo and docs
b2bec78 
- adds a demo guide for global rate limit of HTTP traffic

- updates existing rate limit docs for consistency

- updates API reference guide

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm-docs that referenced this issue Aug 22, 2022
@shashankram
docs/rate-limit: add global rate limit demo and docs
9ffa1af 
- adds a demo guide for global rate limit of HTTP traffic

- updates existing rate limit docs for consistency

- updates API reference guide

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm-docs that referenced this issue Aug 22, 2022
@shashankram
docs/rate-limit: add global rate limit demo and docs
ae533ad 
- adds a demo guide for global rate limit of HTTP traffic

- updates existing rate limit docs for consistency

- updates API reference guide

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm-docs that referenced this issue Aug 22, 2022
@shashankram
docs/rate-limit: add global rate limit demo and docs
67d3753 
- adds a demo guide for global rate limit of HTTP traffic

- updates existing rate limit docs for consistency

- updates API reference guide

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram moved this from In Progress to Blocked in OSM Roadmap (dev) Aug 24, 2022
shashankram added a commit that referenced this issue Aug 24, 2022
@shashankram
rate-limit: add global HTTP rate-limit capability (#5009)
b05295f 
- Adds global rate limit capability for HTTP traffic

- Updates global rate limit API to allow setting
  the response code for rate limited requests

- Updates envoyproxy/go-control-plane to v0.10.3
  which includes the latest protos for global
  rate limiting. Also updates proto_types.go
  to reflect the usage of the new pkg version.

- Moves rate limit specific code in LDS to its
  own file

- Unit tests for rate limiting changes introduced

Part of #2018

Signed-off-by: Shashank Ram <[email protected]>

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to openservicemesh/osm-docs that referenced this issue Aug 24, 2022
@shashankram
docs/rate-limit: add global rate limit demo and docs (#433)
4d70b62 
- adds a demo guide for global rate limit of HTTP traffic

- updates existing rate limit docs for consistency

- updates API reference guide

Part of openservicemesh/osm#2018

Signed-off-by: Shashank Ram <[email protected]>

Signed-off-by: Shashank Ram <[email protected]>
@shashankram
Copy link
Member

The core functionality is now complete.

Repository owner moved this from Blocked to Done in OSM Roadmap (dev) Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shashankram shashankram

Labels
kind/feature-request Feature request kind/research-required Requires further research to make progress priority/P0 P0 priority size/XXL 40 days (2 months)
Projects
OSM Roadmap (dev)
Status: Done
Milestone
v1.3
Development

No branches or pull requests
5 participants
@trstringer @michelleN @steeling @shashankram @draychev