-
Notifications
You must be signed in to change notification settings - Fork 154
Fix manual CI workflow and add name
option.
#904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix manual CI workflow and add name
option.
#904
Conversation
Signed-off-by: Yury-Fridlyand <[email protected]>
@@ -2,6 +2,13 @@ name: SQL Plugin Tests | |||
|
|||
on: | |||
workflow_dispatch: | |||
inputs: | |||
name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a description, maybe with example? <branch name> @ <commit sha>
@@ -2,6 +2,13 @@ name: SQL Plugin Tests | |||
|
|||
on: | |||
workflow_dispatch: | |||
inputs: | |||
name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we call this branch_commit
or similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a custom run name which could be specified to override the default value. Default is <branch name> @ <commit sha>
This comment was marked as spam.
This comment was marked as spam.
What is the use case of the workflow? |
It is supposed to run on dev/dbg branches to get results from all tests. This workflow could be triggered manually only. |
Please do not backport to main which is not stable now. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-904-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccc223099f142386f260558d78b039dc50994d1f
# Push it to GitHub
git push --set-upstream origin backport/backport-904-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
Why backport always fail? Is something broken? |
…orkflow Fix manual CI workflow and add `name` option. (cherry picked from commit ccc2230) Signed-off-by: Yury-Fridlyand <[email protected]>
Fix manual CI workflow and add `name` option. (cherry picked from commit ccc2230) Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand [email protected]
Description
name
optional parameter; If not given<branch name> @ <commit sha>
is used.Issues Resolved
Workflow ignored all test errors and reported always success. Workflow was introduced in #837.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.