Skip to content

Add any case of arguments in relevancy based functions to be allowed #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MitchellGale
Copy link
Contributor

Description

Allows for any case on argument name for relevancy based function (Match Phrase Prefix, Simple Query String, Match Bool Prefix, Match, Multi-Match, Query String, Relevance, Simple Query String).
e.g.
AnalyZer can work instead of just analyzer
Zero_Terms_Query can work instead of just zero_terms_query
BOOst can work instead of just boost

Allows for zero_term_query arguments to be of any case.
e.g.
All can work instead of ALL

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

MitchellGale and others added 4 commits August 8, 2022 14:08
…elevancy based functions. Added unit tests to cover updates.

Signed-off-by: MitchellGale-BitQuill <[email protected]>
…ropriate2

Add any case of arguments in relevancy based functions to be allowed
@MitchellGale MitchellGale requested a review from a team as a code owner August 10, 2022 15:38
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #744 (d7fe5c6) into main (29f1c52) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #744   +/-   ##
=========================================
  Coverage     94.78%   94.79%           
- Complexity     2880     2882    +2     
=========================================
  Files           286      286           
  Lines          7735     7741    +6     
  Branches        565      565           
=========================================
+ Hits           7332     7338    +6     
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ilter/lucene/relevance/MatchPhrasePrefixQuery.java 100.00% <100.00%> (ø)
...ript/filter/lucene/relevance/MatchPhraseQuery.java 100.00% <100.00%> (ø)
...age/script/filter/lucene/relevance/MatchQuery.java 100.00% <100.00%> (ø)
...cript/filter/lucene/relevance/MultiMatchQuery.java 100.00% <100.00%> (ø)
...ript/filter/lucene/relevance/QueryStringQuery.java 100.00% <100.00%> (ø)
...script/filter/lucene/relevance/RelevanceQuery.java 100.00% <100.00%> (ø)
...ilter/lucene/relevance/SimpleQueryStringQuery.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen merged commit ac9b63a into opensearch-project:main Aug 15, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the integ-RelFunc_changeCaseWhereAppropriate branch January 12, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants