Skip to content

Bump JDBC driver's dependency version #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Aug 8, 2022

Description

Bump dependency version:

  1. Httpclient
  2. Wiremock (test dependency)
  3. Guava (test dependency introduced by wiremock)
  4. Json-smart (test dependency introduced by wiremock)

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added the JDBC label Aug 8, 2022
@dai-chen dai-chen self-assigned this Aug 8, 2022
@dai-chen dai-chen marked this pull request as ready for review August 8, 2022 23:30
@dai-chen dai-chen requested a review from a team as a code owner August 8, 2022 23:30
@codecov-commenter
Copy link

Codecov Report

Merging #735 (7106721) into main (1df89e3) will decrease coverage by 2.97%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #735      +/-   ##
============================================
- Coverage     97.76%   94.78%   -2.98%     
  Complexity     2880     2880              
============================================
  Files           276      286      +10     
  Lines          7077     7735     +658     
  Branches        447      565     +118     
============================================
+ Hits           6919     7332     +413     
- Misses          157      349     +192     
- Partials          1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 97.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
workbench/public/components/PPLPage/PPLPage.tsx 56.52% <0.00%> (ø)
workbench/public/components/Main/main.tsx 53.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen merged commit 29f1c52 into opensearch-project:main Aug 9, 2022
@dai-chen dai-chen deleted the bump-dependency-version-new branch August 9, 2022 18:04
@dai-chen dai-chen added the dependencies Pull requests that update a dependency file label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants