-
Notifications
You must be signed in to change notification settings - Fork 29
Fix CVEs #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVEs #96
Conversation
Signed-off-by: Guian Gumpac <[email protected]>
Can you update release notes? |
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Hi @GumpacG 👋🏻 I work on CodeQL and noticed that you referenced an issue over on the Rather than pinning the older version of CodeQL and missing out on new features and improvements, I would suggest that you build with Java 11 or 17 in the CodeQL workflow as well. The easiest way to accomplish this would be with a manual build by replacing - name: Autobuild
uses: github/codeql-action/autobuild@v2 with - name: Build
run: |
./gradlew --no-daemon -S -Dorg.gradle.dependency.verification=off clean
./gradlew --no-daemon -S -Dorg.gradle.dependency.verification=off testClasses This should give you the same results as with the automatic build, except that the default Java version on the system is used instead of the one that CodeQL infers based on your project configuration. In the case of the GHA runners, the default is currently Java 11. To further improve the workflow's reliability, I would also recommend adding a |
I tested and the suggested solution worked. I'll update. Thanks @mbg. |
Description
Issues Resolved
#5
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.