bump jetty client to 11 0 14 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
pjfitzgibbons,
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz and
Yury-Fridlyand
as code owners
Signed-off-by: Derek Ho <[email protected]>
penghuo
reviewed
May 16, 2023
| @@ -239,6 +239,9 @@ jacocoTestCoverageVerification { | |||
| configurations.all { | |||
| // fixes https://www.mend.io/vulnerability-database/CVE-2023-24998 | |||
| resolutionStrategy.force 'commons-fileupload:commons-fileupload:1.5' | |||
| resolutionStrategy.force 'org.eclipse.jetty:jetty-client:11.0.14' | |||
There was a problem hiding this comment.
qq, jetty-server:11:0.14 conflict with which version?
There was a problem hiding this comment.
Wiremock is bringing in several dependencies under version 11.0.12, which are vulnerable:
+--- com.github.tomakehurst:wiremock:3.0.0-beta-2
| +--- org.eclipse.jetty:jetty-server:11.0.12 -> 11.0.14
| | +--- org.eclipse.jetty.toolchain:jetty-jakarta-servlet-api:5.0.2
| | +--- org.eclipse.jetty:jetty-http:11.0.14
| | | +--- org.eclipse.jetty:jetty-util:11.0.14
| | | | \--- org.slf4j:slf4j-api:2.0.5
| | | +--- org.eclipse.jetty:jetty-io:11.0.14
| | | | +--- org.slf4j:slf4j-api:2.0.5
| | | | \--- org.eclipse.jetty:jetty-util:11.0.14 (*)
| | | \--- org.slf4j:slf4j-api:2.0.5
| | +--- org.eclipse.jetty:jetty-io:11.0.14 (*)
| | \--- org.slf4j:slf4j-api:2.0.5
| +--- org.eclipse.jetty:jetty-servlet:11.0.12
| | +--- org.eclipse.jetty:jetty-security:11.0.12
| | | +--- org.eclipse.jetty:jetty-server:11.0.12 -> 11.0.14 (*)
| | | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| +--- org.eclipse.jetty:jetty-servlets:11.0.12
| | +--- org.eclipse.jetty:jetty-http:11.0.12 -> 11.0.14 (*)
| | +--- org.eclipse.jetty:jetty-util:11.0.12 -> 11.0.14 (*)
| | +--- org.eclipse.jetty:jetty-io:11.0.12 -> 11.0.14 (*)
| | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| +--- org.eclipse.jetty:jetty-webapp:11.0.12
| | +--- org.eclipse.jetty:jetty-servlet:11.0.12 (*)
| | +--- org.eclipse.jetty:jetty-xml:11.0.12
| | | +--- org.eclipse.jetty:jetty-util:11.0.12 -> 11.0.14 (*)
| | | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| +--- org.eclipse.jetty:jetty-proxy:11.0.12
| | +--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| | +--- org.eclipse.jetty:jetty-util:11.0.12 -> 11.0.14 (*)
| | \--- org.eclipse.jetty:jetty-client:11.0.12
| | +--- org.eclipse.jetty:jetty-http:11.0.12 -> 11.0.14 (*)
| | +--- org.eclipse.jetty:jetty-io:11.0.12 -> 11.0.14 (*)
| | +--- org.eclipse.jetty:jetty-alpn-client:11.0.12
| | | +--- org.eclipse.jetty:jetty-io:11.0.12 -> 11.0.14 (*)
| | | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| +--- org.eclipse.jetty.http2:http2-server:11.0.12
| | +--- org.eclipse.jetty.http2:http2-common:11.0.12
| | | +--- org.eclipse.jetty.http2:http2-hpack:11.0.12
| | | | +--- org.eclipse.jetty:jetty-util:11.0.12 -> 11.0.14 (*)
| | | | +--- org.eclipse.jetty:jetty-http:11.0.12 -> 11.0.14 (*)
| | | | +--- org.eclipse.jetty:jetty-io:11.0.12 -> 11.0.14 (*)
| | | | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| | | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| | +--- org.eclipse.jetty:jetty-server:11.0.12 -> 11.0.14 (*)
| | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| +--- org.eclipse.jetty:jetty-alpn-server:11.0.12
| | +--- org.eclipse.jetty:jetty-server:11.0.12 -> 11.0.14 (*)
| | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
| +--- org.eclipse.jetty:jetty-alpn-java-server:11.0.12
| | +--- org.eclipse.jetty:jetty-io:11.0.12 -> 11.0.14 (*)
| | +--- org.eclipse.jetty:jetty-alpn-server:11.0.12 (*)
| | \--- org.slf4j:slf4j-api:2.0.0 -> 2.0.5
dai-chen
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.