Skip to content

Adding Struct Support #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 10, 2023
Merged

Adding Struct Support #73

merged 4 commits into from
May 10, 2023

Conversation

akuzin1
Copy link
Contributor

@akuzin1 akuzin1 commented May 2, 2023 •
edited
Loading

Description

Adds Struct support to driver.

Issues Resolved

#65

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Yury-Fridlyand
Yury-Fridlyand reviewed May 3, 2023
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
You need to add unit tests, integration tests and fix DCO.

src/main/java/org/opensearch/jdbc/types/TypeConverters.java Outdated
Comment on lines 71 to 74
private static final Set<Class> supportedJavaClasses = Collections.unmodifiableSet(
new HashSet<>(Arrays.asList(
Struct.class
)));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ... = Set.of(Struct.class);? If it is available in this version of java.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah so for where we are using the JDBC driver we need java 8 support, so wouldn't be able to use the java 11 collections apis.

@akuzin1
Adding Struct Support
a1bbf04 
Signed-off-by: Andrey Kuzin <[email protected]>
Yury-Fridlyand
Yury-Fridlyand approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you build the driver and run an OpenSearch cluster with corresponding data and verify that everything works fine now?
Few screenshots from a DB management tool showing before and after your fix would a great proof.
I can provide you a sample data for tests if you need.

@akuzin1
Copy link
Contributor Author

akuzin1 commented May 5, 2023

Yeah I can definitely do that and any sample data would be great to have. Thank you.

@akuzin1
Copy link
Contributor Author

akuzin1 commented May 5, 2023

Here are a couple screenshots documenting the behavior before and after the above change when using the sql jdbc driver to query OpenSearch index with structs.
Before:
Screenshot 2023-05-05 at 2 04 57 PM
After:
Screenshot 2023-05-05 at 1 20 01 PM

Before:
Screenshot 2023-05-05 at 2 02 26 PM
After:
Screenshot 2023-05-05 at 1 35 16 PM

acarbonetto
acarbonetto approved these changes May 5, 2023
View reviewed changes
@akuzin1
Minor refactoring changes
edc3f47 
Signed-off-by: Andrey Kuzin <[email protected]>
dai-chen
dai-chen reviewed May 8, 2023
View reviewed changes
penghuo
penghuo approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

dai-chen
dai-chen approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen merged commit c0ce14f into opensearch-project:main May 10, 2023
@dai-chen dai-chen added the enhancement New feature or request label May 10, 2023
@akuzin1 akuzin1 mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@penghuo penghuo penghuo approved these changes

@dai-chen dai-chen dai-chen approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akuzin1 @penghuo @dai-chen @Yury-Fridlyand @acarbonetto