Skip to content

Update jenkins file to use updated docker image #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jul 7, 2023

Description

We recently upgraded the python version in the build repo. Due to this any code using build repo code fails if right python version is not used. Signing artifacts uses the build repo code hence updating the image to most recent one.

Issues Resolved

opensearch-project/opensearch-build#3712

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/opensearch-project/opensearch-build/blob/main/DEVELOPER_GUIDE.md#install-prerequisites
this still says install 3.7, does it mean the instructions are outdated?

also is python 3.9.7 the only supported python version, or 3.9.x are ok? i see opensearchstaging/ci-runner:release-centos7-clients-v4 uses 3.9.7

@gaiksaya
Copy link
Member Author

gaiksaya commented Jul 7, 2023

https://github.com/opensearch-project/opensearch-build/blob/main/DEVELOPER_GUIDE.md#install-prerequisites this still says install 3.7, does it mean the instructions are outdated?

also is python 3.9.7 the only supported python version, or 3.9.x are ok? i see opensearchstaging/ci-runner:release-centos7-clients-v4 uses 3.9.7

Yes @peterzhuamazon is working on updating the developer guide. Any 3.9.x should work. However since it clones build repo and has a piplock file it bootstraps with the same which is fixated to 3.9.7

@gaiksaya gaiksaya deleted the fix-jenkins branch July 7, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants