Use extendedPlugins in integrationTest framework for sample resource plugin testing #5322
+96
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mework Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997,
reta,
shikharj05 and
willyborankin
as code owners
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5322 +/- ##
==========================================
+ Coverage 71.76% 72.01% +0.25%
==========================================
Files 384 384
Lines 23882 23905 +23
Branches 3648 3651 +3
==========================================
+ Hits 17139 17216 +77
+ Misses 4912 4855 -57
- Partials 1831 1834 +3
🚀 New features to boost your workflow:
|
| @@ -72,7 +71,7 @@ private SharedWithActionGroup.ActionGroupRecipients parseRevokedEntities(Map<Str | |||
| throw new IllegalArgumentException("entities_to_revoke is required and cannot be empty"); | |||
| } | |||
|
|
|||
| Map<Recipient, Set<String>> entitiesToRevoke = source.entrySet() | |||
| Map<Recipient, Collection<String>> entitiesToRevoke = source.entrySet() | |||
spi/src/main/java/org/opensearch/security/spi/resources/sharing/SharedWithActionGroup.java
Outdated
Show resolved
Hide resolved
spi/src/main/java/org/opensearch/security/spi/resources/sharing/ShareWith.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR takes advantage of the changes in opensearch-project/OpenSearch#16908 to setup the integrationTests in the sample-resource-plugin using extendedPlugins instead of the workaround that was introduced.
This PR also does a little refactoring on the
shareflow to modify sharing info of a resource in memory instead of painless which was failing for me locally in testing.Refactoring
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.