Skip to content

Allow integrationTestFramework to use new constructor of Node that accepts pluginInfos #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented May 8, 2025

Description

This PR reacts to changes in core from opensearch-project/OpenSearch#16908 that changed the constructor of Node.java to take a collection of PluginInfo instead of a simple list of classes to allow the integration tests to be more flexible and ultimately allow defining extended plugins within tests.

This change is needed to fix a compilation error due to the change in core and the security plugin's integrationTest framework.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Test fix

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks added 3 commits May 8, 2025 10:51
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Copy link
Member Author

cwperks commented May 8, 2025

Merging this PR as its fixing a compilation issue in this repo that is blocking other PRs.

@cwperks cwperks merged commit dfe16b0 into opensearch-project:main May 8, 2025
41 checks passed
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.78%. Comparing base (6e78dd9) to head (b5c86be).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5321      +/-   ##
==========================================
+ Coverage   71.68%   71.78%   +0.09%     
==========================================
  Files         384      384              
  Lines       23869    23870       +1     
  Branches     3647     3648       +1     
==========================================
+ Hits        17111    17135      +24     
+ Misses       4928     4903      -25     
- Partials     1830     1832       +2     
Files with missing lines Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 83.93% <100.00%> (+0.66%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants