Skip to content

[Backport 3.0] [Resource Permissions] Introduces Centralized Resource Access Control Framework #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 68babe0 from #5281.

… Framework (#5281)

Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 68babe0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 65.70486% with 416 lines in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (280d8e5) to head (b590a53).
Report is 5 commits behind head on 3.0.

Files with missing lines Patch % Lines
...ecurity/resources/ResourceSharingIndexHandler.java 57.98% 112 Missing and 9 partials ⚠️
...ecurity/spi/resources/sharing/ResourceSharing.java 50.60% 36 Missing and 5 partials ⚠️
...arch/security/resources/ResourceAccessHandler.java 66.66% 25 Missing and 11 partials ⚠️
...arch/security/resources/ResourceIndexListener.java 16.12% 26 Missing ⚠️
...y/spi/resources/sharing/SharedWithActionGroup.java 64.81% 17 Missing and 2 partials ⚠️
...arch/security/spi/resources/sharing/CreatedBy.java 46.15% 12 Missing and 2 partials ⚠️
...ain/java/org/opensearch/sample/SampleResource.java 64.70% 12 Missing ⚠️
...tions/transport/DeleteResourceTransportAction.java 69.44% 9 Missing and 2 partials ⚠️
.../opensearch/security/OpenSearchSecurityPlugin.java 74.41% 9 Missing and 2 partials ⚠️
...arch/security/spi/resources/sharing/ShareWith.java 64.00% 7 Missing and 2 partials ⚠️
... and 27 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #5289      +/-   ##
==========================================
- Coverage   72.05%   71.71%   -0.35%     
==========================================
  Files         336      384      +48     
  Lines       22648    23858    +1210     
  Branches     3560     3632      +72     
==========================================
+ Hits        16320    17109     +789     
- Misses       4554     4926     +372     
- Partials     1774     1823      +49     
Files with missing lines Coverage Δ
...va/org/opensearch/sample/SampleResourcePlugin.java 100.00% <100.00%> (ø)
...urce/actions/rest/create/CreateResourceAction.java 100.00% <100.00%> (ø)
...urce/actions/rest/create/UpdateResourceAction.java 100.00% <100.00%> (ø)
...urce/actions/rest/delete/DeleteResourceAction.java 100.00% <100.00%> (ø)
...e/resource/actions/rest/get/GetResourceAction.java 100.00% <100.00%> (ø)
...source/actions/rest/get/GetResourceRestAction.java 100.00% <100.00%> (ø)
...ctions/rest/revoke/RevokeResourceAccessAction.java 100.00% <100.00%> (ø)
...source/actions/rest/share/ShareResourceAction.java 100.00% <100.00%> (ø)
...transport/RevokeResourceAccessTransportAction.java 100.00% <100.00%> (ø)
...resource/client/ResourceSharingClientAccessor.java 100.00% <100.00%> (ø)
... and 44 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peterzhuamazon peterzhuamazon marked this pull request as draft April 25, 2025 17:15
@cwperks cwperks closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants