Skip to content

Remove OpenSSL provider #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Mar 27, 2025

Description

Support for configuring OpenSSL as a TLS provider was not supported when running with JDK > 11. Since 3.0.0 has minimum compatibility with JDK 21 its no longer possible to configure the OpenSSL provider. I am raising this PR to remove the code around configuring the OpenSSL provider.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (6688955) to head (5ebaa42).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ensearch/security/ssl/DefaultSecurityKeyStore.java 25.00% 2 Missing and 4 partials ⚠️
.../opensearch/security/ssl/config/SslParameters.java 71.42% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5220      +/-   ##
==========================================
+ Coverage   71.71%   71.96%   +0.24%     
==========================================
  Files         337      337              
  Lines       22793    22661     -132     
  Branches     3607     3564      -43     
==========================================
- Hits        16347    16307      -40     
+ Misses       4649     4585      -64     
+ Partials     1797     1769      -28     
Files with missing lines Coverage Δ
...arch/security/ssl/OpenSearchSecuritySSLPlugin.java 87.39% <ø> (+0.15%) ⬆️
...rg/opensearch/security/ssl/SslSettingsManager.java 78.20% <ø> (+5.12%) ⬆️
...earch/security/ssl/rest/SecuritySSLInfoAction.java 78.33% <ø> (-0.78%) ⬇️
...ensearch/security/ssl/util/SSLConfigConstants.java 77.77% <ø> (-1.39%) ⬇️
.../opensearch/security/ssl/config/SslParameters.java 76.92% <71.42%> (+19.97%) ⬆️
...ensearch/security/ssl/DefaultSecurityKeyStore.java 30.63% <25.00%> (+3.58%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks cwperks marked this pull request as ready for review April 1, 2025 14:42
@cwperks
Copy link
Member Author

cwperks commented Apr 1, 2025

Since this PR would remove the CI check opensslCITest, the branch protection rules will need to be updated to remove those as required checks.

@cwperks
Copy link
Member Author

cwperks commented Apr 9, 2025

I will submit a documentation PR to remove any references to plugins.security.ssl.transport.enable_openssl_if_available or plugins.security.ssl.http.enable_openssl_if_available

@cwperks cwperks merged commit 94eab92 into opensearch-project:main Apr 9, 2025
40 of 41 checks passed
@cwperks
Copy link
Member Author

cwperks commented Apr 9, 2025

Created documentation PR: opensearch-project/documentation-website#9588

DarshitChanpura pushed a commit to DarshitChanpura/security that referenced this pull request Apr 21, 2025
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants