Skip to content

Fixes version matcher string in demo config installer #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DarshitChanpura
Copy link
Member

Description

A bug was discovered in Installer.java while working on #5016, where the version matcher string matched everything after opensearch-security. WIth #5016 introducing packages like opensearch-security-client and openserch-secrurity-common the version matcher spewed out common-3.0.0.0 instead out 3.0.0.0. This PR fixes it to only spew out the version along with qualifier and snapshot string.

Issues Resolved

unblocks #5016

Testing

Unit tests

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.70%. Comparing base (8803690) to head (bc9590a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5157      +/-   ##
==========================================
+ Coverage   71.69%   71.70%   +0.01%     
==========================================
  Files         337      337              
  Lines       22781    22783       +2     
  Branches     3604     3604              
==========================================
+ Hits        16332    16336       +4     
+ Misses       4647     4645       -2     
  Partials     1802     1802              
Files with missing lines Coverage Δ
...pensearch/security/tools/democonfig/Installer.java 72.25% <100.00%> (+0.90%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DarshitChanpura DarshitChanpura merged commit 9e36031 into opensearch-project:main Mar 8, 2025
42 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 8, 2025
(cherry picked from commit 9e36031)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants