Removes beta1 qualifier and solves CVE-2024-52798 #2231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#2230) * Changes to remove tenant panels from roles pages when multitenancy is disabled (opensearch-project#2215) (opensearch-project#2218) * Changes to remove tenant panels from roles pages when multitenancy is disabled * Modified test files as per comments on PR --------- (cherry picked from commit e7ffb2e) * Explicitly cd to security-dashboards-plugin directory before running cypress tests (opensearch-project#2216) (opensearch-project#2222) (cherry picked from commit d17ac9e) * Add cat shard api permission (opensearch-project#2217) (opensearch-project#2223) (cherry picked from commit f0baa61) * Increment version to 3.0.0.0 (opensearch-project#2226) * Removes beta1 qualifier from security-dashboards-plugin --------- (cherry picked from commit cf24968) Signed-off-by: nishthm <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Swetha Guptha <[email protected]> Signed-off-by: opensearch-ci-bot <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Swetha Guptha <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
requested review from
cwperks,
derek-ho and
RyanL1997
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2231 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 98 98
Lines 2691 2691
Branches 420 412 -8
=======================================
Hits 1938 1938
Misses 638 638
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwperks
approved these changes
Apr 29, 2025
RyanL1997
approved these changes
Apr 29, 2025
|
should we merge this in? @cwperks @DarshitChanpura |
|
Yes we can merge this. Eventually the express test dependency should be removed once the node-based SAML IdP is replaced (maybe with Keycloak) for testing: #2182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://advisories.opensearch.org/advisories/CVE-2024-52798 and forward-ports #2229
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.