Fix openid redirect issue to use base_redirect_url when nextUrl is absent #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sent Signed-off-by: Craig Perkins <[email protected]>
DarshitChanpura
approved these changes
Dec 24, 2022
RyanL1997
approved these changes
Dec 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #1282 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 274 274
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@cwperks Should this one be backported? |
|
@RyanL1997 Yes! This can be backported to 2.x. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 27, 2022
…sent (#1282) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit db1fbb9)
RyanL1997
pushed a commit
that referenced
this pull request
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Perkins [email protected]
Description
Fixes an issue on openid login that redirects to
/when aopensearch_security.openid.base_redirect_urlis present and anextUrlquery param is absent.opensearch_security.openid.base_redirect_urlis configured inopensearch_dashboards.ymland often matches theserver.basePathwhich is the root url for OSD. On successful login, the user should be routed to the redirect url if nextUrl is absent.Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Bug fix
Issues Resolved
#1098
Testing
Adds 2 new unit tests to test when request.query.nextUrl is present and when it is absent to use the config.openid?.base_redirect_url
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.