Skip to content

[Backport 2.12] Add throw for empty strings in rules with modifier contains, startwith, and endswith #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.12
Choose a base branch
from
Open

[Backport 2.12] Add throw for empty strings in rules with modifier contains, startwith, and endswith #887

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f4ee7bb from #860

@jowg-amazon @github-actions
Add throw for empty strings in rules with modifier contains, startwit…
32cc545 
…h, and endswith (#860)

* add validation for empty strings with contains, startswith and endswith modifiers

Signed-off-by: Joanne Wang <[email protected]>

* throw exception if empty string with contains, startswith, or endswith

Signed-off-by: Joanne Wang <[email protected]>

* change var name

Signed-off-by: Joanne Wang <[email protected]>

* add modifiers to log

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit f4ee7bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engechas engechas engechas approved these changes

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@AWSHurneyt AWSHurneyt Awaiting requested review from AWSHurneyt AWSHurneyt is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

@jowg-amazon jowg-amazon Awaiting requested review from jowg-amazon jowg-amazon is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Security Analytics Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engechas @jowg-amazon