Skip to content

Removed create/delete queryIndex #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 10, 2023

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Dec 31, 2022

Description

Instead of creating and deleting queryIndex, SA will now just setup an Index Template with needed settings for all query indicies of all detectorTypes

Issues Resolved

179

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team December 31, 2022 00:54
Copy link
Collaborator

@sbcd90 sbcd90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alerting pr is merged but builds will pass only when security-analytics version is incremented.

@codecov-commenter
Copy link

Codecov Report

Merging #215 (f745e04) into main (31c69ac) will increase coverage by 0.17%.
The diff coverage is 36.84%.

@@             Coverage Diff              @@
##               main     #215      +/-   ##
============================================
+ Coverage     38.85%   39.02%   +0.17%     
- Complexity      892      894       +2     
============================================
  Files           176      176              
  Lines          6767     6754      -13     
  Branches        828      827       -1     
============================================
+ Hits           2629     2636       +7     
+ Misses         3897     3878      -19     
+ Partials        241      240       -1     
Impacted Files Coverage Δ
.../transport/TransportCreateIndexMappingsAction.java 0.00% <ø> (ø)
...ytics/transport/TransportDeleteDetectorAction.java 0.00% <0.00%> (ø)
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
...earch/securityanalytics/util/RuleTopicIndices.java 0.00% <0.00%> (ø)
...alytics/config/monitors/DetectorMonitorConfig.java 51.21% <20.00%> (-2.63%) ⬇️
...search/securityanalytics/mapper/MapperService.java 37.24% <62.50%> (+2.89%) ⬆️
...ensearch/securityanalytics/mapper/MapperUtils.java 54.41% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit 6ce8d6e into opensearch-project:main Jan 10, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-215-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6ce8d6e0dd1db6446e62a27f182bfc7cf1e325e4
# Push it to GitHub
git push --set-upstream origin backport/backport-215-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-215-to-2.x.

sbcd90 pushed a commit to sbcd90/security-analytics that referenced this pull request Jan 10, 2023
sbcd90 added a commit that referenced this pull request Jan 10, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
Co-authored-by: Petar Dzepina <[email protected]>
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants