Correlate findings in batches #1539
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
reviewed
Jun 12, 2025
build.gradle
Outdated
| @@ -210,7 +210,7 @@ dependencies { | |||
| implementation 'com.jayway.jsonpath:json-path:2.9.0' | |||
| implementation 'net.minidev:json-smart:2.5.2' | |||
| implementation 'net.minidev:accessors-smart:2.5.2' | |||
| compileOnly "com.google.guava:guava:32.1.3-jre" | |||
| implementation "com.google.guava:guava:32.1.3-jre" | |||
toepkerd
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
…gent (opensearch-project#1504) Signed-off-by: Dennis Toepker <[email protected]>
… of Java-agent. (opensearch-project#1505) * Revert "Fix build due to phasing off SecurityManager usage in favor of Java Agent (opensearch-project#1504)" This reverts commit d6ddd5b. Signed-off-by: Pranav Reddy <[email protected]> * Using java-agent gradle plugin to phase off Security Manager in favor of Java-agent. Signed-off-by: Pranav Reddy <[email protected]> --------- Signed-off-by: Pranav Reddy <[email protected]> Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: vikhy-aws <[email protected]> Signed-off-by: Dennis Toepker <[email protected]>
…1520) (cherry picked from commit e4fc510) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: Dennis Toepker <[email protected]>
* added release notes for 3.0 Signed-off-by: Riya Saxena <[email protected]> * added release notes for 3.0 Signed-off-by: Riya Saxena <[email protected]> * Update opensearch-security-analytics.release-notes-3.0.0.0.md Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: Dennis Toepker <[email protected]>
…ect#1530) * Switch guava deps from compileOnly to implementation Signed-off-by: Craig Perkins <[email protected]> * Use AccessController Signed-off-by: Craig Perkins <[email protected]> * Use getResource Signed-off-by: Craig Perkins <[email protected]> * Use getResourceAsStream Signed-off-by: Craig Perkins <[email protected]> * Try removing lead forward slash Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
remove test verifying index pattern behaviour in detector
eirsep
requested changes
Jun 18, 2025
| @@ -116,6 +125,7 @@ public TransportCorrelateFindingAction(TransportService transportService, | |||
| this.xContentRegistry = xContentRegistry; | |||
| this.detectorIndices = detectorIndices; | |||
| this.correlationIndices = correlationIndices; | |||
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correlations now correlates findings in batches synchronously instead of starting a task for each individual finding. Also performs some prechecks before even correlating in the first place:
For Reviewers
The only file with meaningful changes is TransportCorrelateFindingAction.java, below is a guide to direct your attention to the most important changes:
Related Issues
#1537
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.