Skip to content

Toggle all rules button on detector edit page #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Toggle all rules button on detector edit page #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6817e4
toggle all rules button on detector edit page
djindjic Dec 19, 2022
b8d6e5e
Merge branch 'opensearch-project:main' into featture/122-enable-disab…
djindjic Dec 19, 2022
c0ea955
Merge branch 'opensearch-project:main' into featture/122-enable-disab…
djindjic Dec 19, 2022
a216a1a
Merge branch 'opensearch-project:main' into featture/122-enable-disab…
djindjic Dec 21, 2022
ddd4111
adding toggle all - adds hidden button into table
djindjic Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cypress/integration/1_detectors.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ describe('Detectors', () => {
cy.contains('tr', 'USB Device Plugged').within(() => {
// Of note, timeout can sometimes work instead of wait here, but is very unreliable from case to case.
cy.wait(1000);
cy.get('button').eq(0).click();
cy.get('button').eq(1).click();
});

// Save changes
Expand All @@ -246,7 +246,7 @@ describe('Detectors', () => {
// Toggle single search result to checked
cy.contains('tr', 'USB Device Plugged').within(() => {
cy.wait(2000);
cy.get('button').eq(0).click({ force: true });
cy.get('button').eq(1).click({ force: true });
});

// Save changes
Expand Down
6 changes: 6 additions & 0 deletions public/pages/Detectors/components/UpdateRules/UpdateRules.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,11 @@ export const UpdateDetectorRules: React.FC<UpdateDetectorRulesProps> = (props) =
}
};

const onAllRulesToggle = (isActive: boolean) => {
setCustomRuleItems(customRuleItems.map((rule) => ({ ...rule, active: isActive })));
setPrePackagedRuleItems(prePackagedRuleItems.map((rule) => ({ ...rule, active: isActive })));
};

const onCancel = useCallback(() => {
props.history.replace({
pathname: `${ROUTES.DETECTOR_DETAILS}/${detectorId}`,
Expand Down Expand Up @@ -216,6 +221,7 @@ export const UpdateDetectorRules: React.FC<UpdateDetectorRulesProps> = (props) =
loading={loading}
ruleItems={ruleItems}
onRuleActivationToggle={onToggle}
onAllRulesToggled={onAllRulesToggle}
/>

<EuiSpacer size="xl" />
Expand Down