Change model for Judgment entity #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
changed_model_for_judgments
branch
from
35c5546 to
efa8af2
Compare
martin-gaievski
changed the title
heemin32
approved these changes
Jun 8, 2025
| for (Map.Entry<String, Object> queryEntry : sourceJudgementRatings.entrySet()) { | ||
| String queryText = queryEntry.getKey(); | ||
| Object ratingData = queryEntry.getValue(); | ||
| // for (Map.Entry<String, Object> queryEntry : sourceJudgementRatings.entrySet()) { |
There was a problem hiding this comment.
Suggested change
| // for (Map.Entry<String, Object> queryEntry : sourceJudgementRatings.entrySet()) { |
| ) { | ||
| Map<String, List<String>> indexAndQueries = (Map<String, List<String>>) results.get(METRICS_INDEX_AND_QUERIES_FIELD_NAME); | ||
| List<String> queryTextWithReferences = (List<String>) results.get(METRICS_QUERY_TEXT_FIELD_NAME); | ||
|
|
||
| Map<String, Map<String, String>> allJudgments = new HashMap<>(); | ||
| // Map<String, Map<String, String>> allJudgments = new HashMap<>(); |
There was a problem hiding this comment.
Suggested change
| // Map<String, Map<String, String>> allJudgments = new HashMap<>(); | |
| @Override | ||
| public void onResponse(Map<String, String> docIdToScore) { | ||
| synchronized (allJudgments) { | ||
| allJudgments.put(queryTextWithReference, docIdToScore); | ||
| // allJudgments.put(queryTextWithReference, docIdToScore); |
There was a problem hiding this comment.
Suggested change
| // allJudgments.put(queryTextWithReference, docIdToScore); |
| ) { | ||
| LOGGER.debug("Starting COEC calculation with rank CTR: {}", rankAggregatedClickThrough); | ||
| Map<String, Map<String, String>> judgmentRatings = new HashMap<>(); | ||
| // Map<String, Map<String, String>> judgmentRatings = new HashMap<>(); |
There was a problem hiding this comment.
Suggested change
| // Map<String, Map<String, String>> judgmentRatings = new HashMap<>(); |
| } | ||
| LOGGER.debug( | ||
| "Final judgment ratings size - Queries: {}, Total Documents: {}", | ||
| judgmentRatings.size(), | ||
| judgmentRatings.values().stream().mapToInt(Map::size).sum() | ||
| // judgmentRatings.values().stream().mapToInt(Map::size).sum() |
There was a problem hiding this comment.
Suggested change
| // judgmentRatings.values().stream().mapToInt(Map::size).sum() |
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| super.writeTo(out); | ||
| out.writeMap(judgmentScores); | ||
| // out.writeList(judgmentScores); |
There was a problem hiding this comment.
Suggested change
| // out.writeList(judgmentScores); |
Signed-off-by: Martin Gaievski <[email protected]>
corrected, thanks @heemin32 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================
==========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jun 9, 2025
wrigleyDan
added a commit
to wrigleyDan/search-relevance
that referenced
this pull request
Jun 10, 2025
…pensearch-project#77 Signed-off-by: wrigleyDan <[email protected]>
wrigleyDan
added a commit
that referenced
this pull request
Jun 10, 2025
* fix implicit judgment for the new nested data structure introduced in #77 Signed-off-by: wrigleyDan <[email protected]> * run ./gradlew spotlessApply Signed-off-by: wrigleyDan <[email protected]> * add entry to CHANGELOG.md Signed-off-by: wrigleyDan <[email protected]> * edit comment as per suggestion Signed-off-by: wrigleyDan <[email protected]> --------- Signed-off-by: wrigleyDan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the model for Judgments to use fixed set of fields instead of dynamic field for each query text. Example of Judgment object with new model:
In this PR following items got changed:
Issues Resolved
#71
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.