Skip to content

Revert "Upgrade to version: minimatch - 3.0.5" #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Revert "Upgrade to version: minimatch - 3.0.5" #516

wants to merge 1 commit into from

Conversation

rupal-bq
Copy link
Contributor

Reverts #512

minimatch is present in Opensearch-Dashboards, no need to add it here.
Ref: #513 (comment)

@rupal-bq rupal-bq requested a review from a team as a code owner October 26, 2022 22:37
This reverts commit a1248a9.

Signed-off-by: Rupal Mahajan <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #516 (46e20b1) into main (a1248a9) will not change coverage.
The diff coverage is n/a.

❗ Current head 46e20b1 differs from pull request most recent head d67c0fb. Consider uploading reports for the commit d67c0fb to get more accurate results

@@            Coverage Diff            @@
##               main     #516   +/-   ##
=========================================
  Coverage     74.27%   74.27%           
  Complexity      383      383           
=========================================
  Files            94       94           
  Lines          3984     3984           
  Branches        641      641           
=========================================
  Hits           2959     2959           
  Misses          891      891           
  Partials        134      134           
Flag Coverage Δ
dashboards-reports 76.85% <ø> (ø)
reports-scheduler 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuali925
Copy link
Member

q: #513 (comment)

@rupal-bq
Copy link
Contributor Author

Closing this PR since Opensearch Dashboards 2.x has minimatch v3.0.5 but reports 2.x still has v3.0.4

@rupal-bq rupal-bq closed this Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants