Skip to content

Add action to refresh search analyzers to ISM plugin client #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ste93cry
Copy link

Description

The changes in this merge request focus on adding support for refreshing the search analyzers to the client of the ISM plugin.

Issues Resolved

Closes #678

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 12 lines in your changes missing coverage. Please review.

Project coverage is 60.29%. Comparing base (06a6dc8) to head (3e4dd8c).
Report is 92 commits behind head on main.

Files with missing lines Patch % Lines
plugins/ism/api_refresh_search_analyzers-params.go 25.00% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   57.29%   60.29%   +2.99%     
==========================================
  Files         315      378      +63     
  Lines        9823    11630    +1807     
==========================================
+ Hits         5628     7012    +1384     
- Misses       2902     3187     +285     
- Partials     1293     1431     +138     
Flag Coverage Δ
integration 52.78% <72.72%> (+1.94%) ⬆️
unit 14.83% <ø> (+1.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
plugins/ism/api_refresh_search_analyzers.go 100.00% <100.00%> (ø)
plugins/ism/api_refresh_search_analyzers-params.go 25.00% <25.00%> (ø)

... and 105 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ste93cry ste93cry force-pushed the support-reload-search-analyzers-api-endpoint branch 2 times, most recently from 1c2cd21 to 75b74fe Compare March 25, 2025 23:56
@ste93cry ste93cry force-pushed the support-reload-search-analyzers-api-endpoint branch from 75b74fe to 3e4dd8c Compare March 25, 2025 23:58
@ste93cry
Copy link
Author

Test failures look unrelated to my changes. I think integration tests are a bit flaky, but I have no permission to restart the failed jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Expose the action to refresh the search analyzers
1 participant