-
Notifications
You must be signed in to change notification settings - Fork 294
update search and observability plugins #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update search and observability plugins
The DCO check failed, needs a -s amend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked on other PRs. Also will need to rebase since manifest was updated.
NIT: Commit message could be a little bit more descriptive.
- name: queryWorkbenchDashboards | ||
repository: https://github.com/opensearch-project/sql.git | ||
working_directory: workbench | ||
ref: "1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref
refers to the git branch. It will fail if the "1.2" branch doesn't exist so most likely this will be main
until the repo cuts a 1.2
branch. Also there is a PR to bump this up: opensearch-project/sql#254. This PR will need to be merged before we can add it to the manifest.
- name: reportsDashboards | ||
repository: https://github.com/opensearch-project/dashboards-reports.git | ||
working_directory: dashboards-reports | ||
ref: "1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above but: opensearch-project/reporting#203
ref: "1.2" | ||
- name: traceAnalyticsDashboards | ||
repository: https://github.com/opensearch-project/trace-analytics.git | ||
ref: "1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above but: opensearch-project/observability#189
- name: ganttChartDashboards | ||
repository: https://github.com/opensearch-project/dashboards-visualizations | ||
working_directory: gantt-chart | ||
ref: "1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was is all good! 1.2
branch exists and plugin is bumped! If anything it might be easiest to pull this one into another PR so that it's not blocked waiting on the other PRs.
branch is in this repo I can't force push, i'll open another PR |
@anirudha Please make branches off your fork. |
update search and observability plugins for 1.2
Signed-off-by: Anirudha Jadhav [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.