Switch k-NN repo path to logs dir to avoid pathing issues on non-windows #5500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
github-project-automation
bot
moved this to Backlog
in OpenSearch Engineering Effectiveness
66 tasks
zelinh
approved these changes
May 2, 2025
github-project-automation
bot
moved this from Backlog
to In review
in OpenSearch Engineering Effectiveness
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
github-project-automation
bot
moved this from In review
to Done
in OpenSearch Engineering Effectiveness
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
gaiksaya
reviewed
May 2, 2025
| @@ -83,7 +83,7 @@ components: | |||
| node.attr.knn_cb_tier: integ | |||
| path.repo: | |||
| - /tmp | |||
| - C:\ | |||
| - logs | |||
There was a problem hiding this comment.
If the integration tests have this (C:/) fixed path configured, they might fail right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch k-NN repo path to logs dir to avoid pathing issues on non-windows
Issues Resolved
#3747
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.