Skip to content

Update jdk based on OS version for increment PRs and fix windows python #5467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Apr 24, 2025

Description

Update jdk based on OS version for increment PRs and fix windows python

Issues Resolved

#3747
mesonbuild/meson#13008

* What went wrong:
A problem occurred configuring root project 'opensearch-anomaly-detection'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not resolve org.opensearch.gradle:build-tools:3.0.0-beta1-SNAPSHOT.
     Required by:
         root project :
      > Dependency requires at least JVM runtime version 21. This build uses a Java 17 JVM.

* Try:
> Run this build using a Java 21 or newer JVM.
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org./

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon changed the title Update jdk based on OS version for increment PRs Update jdk based on OS version for increment PRs and fix windows python Apr 24, 2025
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Apr 24, 2025

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Apr 24, 2025

Maybe this: https://github.com/pypa/pipenv/blob/main/CHANGELOG.md#202441-2025-04-24

This PR completely refactors the pythonfinder module to improve efficiency, reduce logical errors, and fix support for PEP 514 (Python registration in the Windows registry). The refactoring replaces the complex object hierarchy with a more modular, composition-based approach that is easier to maintain and extend.

Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon
Copy link
Member Author

Resolve this after change back to 2023.6.12:


(C:\Users\runneradmin\.virtualenvs\opensearch-build-DrftepRg\Scripts\python.exe
)
      Need python for x86_64, but found x86
      Run-time dependency python found: NO (tried sysconfig)
      
      ..\..\pandas\_libs\tslibs\meson.build:32:7: ERROR: Python dependency not 
found
      
      A full log can be found at 
C:\Users\runneradmin\AppData\Local\Temp\pip-install-rrz3mdma\pandas_ebaa4093e53
64134be1b73fbeffa8162\.mesonpy-vtdzlrgn\build\meson-logs\meson-log.txt
      
  
  note: This error originates from a subprocess, and is likely not a problem 
with pip.
error: metadata-generation-failed

Indeed the change of this PR pypa/pipenv#6360 broke the behavior.

@peterzhuamazon peterzhuamazon merged commit 054b4a9 into opensearch-project:main Apr 24, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Apr 24, 2025
@peterzhuamazon peterzhuamazon deleted the update-3.0-incremental branch April 24, 2025 19:49
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (60f7d1a) to head (0bcb4f1).
Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #5467   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants