Support JDK-24 builds on Jenkins #5426
Conversation
reta
requested review from
peterzhuamazon,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
|
Hi @reta are we in plans to build with jdk24 but still bundle jdk21? cc: @getsaurabh02 @prudhvigodithi @rishabh6788 Thanks. |
| @@ -84,7 +84,7 @@ regedit /s $zlibRegFilePath | |||
| # Temurin jdk does not have all the versions supported on scoop, especially version 14, 20, and above | |||
| # As of now we will mix temurin and openjdk as temurin for production has support policies for fixes and patches | |||
| # We need to make sure we do not mis-install temurin and openjdk with the same version or the distribution build code will have issues | |||
| $jdkVersionList = "temurin8-jdk JAVA8_HOME", "temurin11-jdk JAVA11_HOME", "openjdk14 JAVA14_HOME", "temurin17-jdk JAVA17_HOME", "temurin19-jdk JAVA19_HOME", "openjdk20 JAVA20_HOME", "temurin21-jdk JAVA21_HOME", "temurin23-jdk JAVA23_HOME" | |||
| $jdkVersionList = "temurin8-jdk JAVA8_HOME", "temurin11-jdk JAVA11_HOME", "openjdk14 JAVA14_HOME", "temurin17-jdk JAVA17_HOME", "temurin19-jdk JAVA19_HOME", "openjdk20 JAVA20_HOME", "temurin21-jdk JAVA21_HOME", "temurin23-jdk JAVA23_HOME", "temurin24-jdk JAVA24_HOME" | |||
There was a problem hiding this comment.
Would need to hold this for a bit as temurin-24 is not available now:
https://scoop.sh/#/apps?q=temurin-24
|
Move to draft for the time being until windows has temurin-24. Thanks. |
Thanks @peterzhuamazon , so the first step is to add JDK-24 to CI, so we could at least have an option to run the check. The work we are doing on Security Manager replacement would let us run on JDK-24 and above (if we pull it off in time for release) |
|
@peterzhuamazon we should be good to go, right? |
|
See it now: https://scoop.sh/#/apps?q=temurin24&p=1 May I suggest starting this once beta1 is out (pending next Tuesday)? Also note that we are still building with jdk21. Are we planning to bundle jdk21 while build with jdk24 for GA? Thanks. |
Sure, we won't be updating core to JDK-24 before that :)
I am not sure we will bundle with JDK-24, unless there would be compelling reasons, we usually always bundle with LTSes |
Yeah I agree with bundling JDK21, just wondering do we need to also build 3.0.0 GA with JDK24. Thanks. |
Yeah, we have to be sure it could run on JDK-24 (but no need to bundle) |
I will put up a note and check it back next Wednesday. |
Signed-off-by: Andriy Redko <[email protected]>
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5426 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We also need a PR to opensearch-ci, but due to we are currently migrating things. Thanks. |
|
Just confirmed that we can just push to opensearch-ci. |
|
Note that windows update mistakenly in servercore again 😅 Thanks. |
Description
Support JDK-24 builds on Jenkins
Issues Resolved
Part of opensearch-project/OpenSearch#17661
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.