Skip to content

Adding anomaly-detection-dashboard plugin to 1.3 manifest #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2022

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky [email protected]

Description

Adding dashboards Anomaly Detection plugin to the 1.3 Dashboards manifest

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz amitgalitz requested a review from a team as a code owner February 10, 2022 20:18
Signed-off-by: Amit Galitzky <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #1616 (78049e3) into main (ad462dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1616   +/-   ##
=========================================
  Coverage     94.67%   94.67%           
  Complexity       13       13           
=========================================
  Files           163      163           
  Lines          3435     3435           
  Branches         21       21           
=========================================
  Hits           3252     3252           
  Misses          180      180           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad462dd...78049e3. Read the comment docs.

Signed-off-by: Amit Galitzky <[email protected]>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amit, could you help rebase the branch since #1614 just merged.

@peternied peternied requested a review from zelinh February 10, 2022 22:15
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peternied peternied merged commit a2db375 into opensearch-project:main Feb 10, 2022
peterzhuamazon pushed a commit to peterzhuamazon/opensearch-build that referenced this pull request Feb 16, 2022
…-project#1616)

* adding Anomaly Detection to 1.3 Dashboard manifest

Signed-off-by: Amit Galitzky <[email protected]>

* linting issue

Signed-off-by: Amit Galitzky <[email protected]>

* fixing linting issue

Signed-off-by: Amit Galitzky <[email protected]>

* linting issue fix after merging main

Signed-off-by: Amit Galitzky <[email protected]>

Co-authored-by: Peter Nied <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants