Skip to content

add ability to use benchmark.ini file to customize redline tests #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

OVI3D0
Copy link
Member

@OVI3D0 OVI3D0 commented Jul 7, 2025

Description

Adds a new [redline] section to benchmark.ini along with some default values for redline testing. These are equivalent to the default values originally used in the FeedbackActor, and allow the user to customize various parts of redline testing from the config object rather than using command flags.

The priority for which value to use is:
command flag -> config object values -> default values in the ConfigureFeedbackScaling class.

And the values that can be customized in the config object include:

  • The scale_step (how many clients are unpaused per tick)
  • The scale_down_percentage (what percentage of clients are scaled down upon an error)
  • The sleep_seconds (how long the FeedbackActor chooses to rest before pushing more load on the host)
  • The cpu_window_seconds (How long of a window the FeedbackActor takes into account when calculating average CPU load)
  • The cpu_check_interval (How often the FeedbackActor queries the datastore to check avg CPU load)

Issues Resolved

#885

Testing

  • New functionality includes testing

Running redline tests with/without various values in the config object


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Michael Oviedo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant