add ability to use benchmark.ini file to customize redline tests #887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
[redline]
section tobenchmark.ini
along with some default values for redline testing. These are equivalent to the default values originally used in the FeedbackActor, and allow the user to customize various parts of redline testing from the config object rather than using command flags.The priority for which value to use is:
command flag -> config object values -> default values in the
ConfigureFeedbackScaling
class.And the values that can be customized in the config object include:
Issues Resolved
#885
Testing
Running redline tests with/without various values in the config object
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.