Change ScriptedMetricAggregate value from true to {} #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xil <[email protected]>
Changes AnalysisCommit SHA: bcb386b API ChangesSummarySUCCESS: No changes found between specifications ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/14977650361/artifacts/3107861698 API Coverage
|
Spec Test Coverage Analysis
|
lucy66hw
requested review from
dblock,
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
karenyrx
reviewed
May 12, 2025
| @@ -1268,7 +1268,7 @@ components: | |||
| - $ref: '#/components/schemas/AggregateBase' | |||
| - type: object | |||
| properties: | |||
| value: true | |||
| value: {} | |||
There was a problem hiding this comment.
just curious, is this the same as
value
type: object
, which was what it was before?
do we have a preference/standard for which one to use for generic object types?
There was a problem hiding this comment.
@karenyrx value isn't necessarily an object, it can also be a float, string etc.
It's of arbitrary type which is why it's unspecified
Xtansia
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change ScriptedMetricAggregate value from true to {}
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.