Skip to content

Added paginationDepth to HybridQuery #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leewjae
Copy link
Contributor

@leewjae leewjae commented Mar 21, 2025

Description

This PR will add paginationDepth to HybridQUery

Issues Resolved

It will close opensearch-project/opensearch-java#1491

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Mar 23, 2025

Changes Analysis

Commit SHA: 1e1e8d4
Comparing To SHA: b88fe06

API Changes

Summary

└─┬Components
  └─┬_common.query_dsl___HybridQuery
    └─┬ALLOF
      ├──[➕] properties (44333:13)
      └─┬queries
        ├──[➖] items (44332:17)❌ 
        ├──[🔀] type (44334:21)❌ 
        └──[➕] format (44335:23)❌ 

Document Element Total Changes Breaking Changes
components 4 6
  • BREAKING Changes: 6 out of 4
  • Modifications: 1
  • Removals: 1
  • Additions: 2
  • Breaking Removals: 1
  • Breaking Modifications: 1
  • Breaking Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/14095725374/artifacts/2827921841

API Coverage

Before After Δ
Covered (%) 663 (64.94 %) 663 (64.94 %) 0 (0 %)
Uncovered (%) 358 (35.06 %) 358 (35.06 %) 0 (0 %)
Unknown 49 49 0

Signed-off-by: Wonjae Lee <[email protected]>
@nhtruong
Copy link
Collaborator

A test failed

@Xtansia
Copy link
Collaborator

Xtansia commented Mar 24, 2025

A test failed

I believe that boils down to the 3.x build being super old, am working on this in #849

@Xtansia Xtansia changed the base branch from main to baseline/3.0.0-alpha1 March 26, 2025 23:50
@Xtansia Xtansia merged commit 50ef290 into opensearch-project:baseline/3.0.0-alpha1 Mar 27, 2025
29 of 32 checks passed
Xtansia added a commit that referenced this pull request Mar 27, 2025
* Update 3.0.0 snapshot image to 3.0.0-alpha1

Signed-off-by: Thomas Farr <[email protected]>

* Allow prerelease versions in semver matching

Signed-off-by: Thomas Farr <[email protected]>

* Fixed swapped schema references in nodes info API buffer fields (#808)

* Fixed swapped schema references in nodes info API buffer fields

Signed-off-by: hye-on <[email protected]>

* Add version specific schema handling for total_indexing_buffer and total_indexing_buffer_in_bytes fields

Signed-off-by: hye-on <[email protected]>

* Fix version number format in nodes.info.yaml

Signed-off-by: hye-on <[email protected]>

* Remove version tags and add notes for schema changes

Signed-off-by: hye-on <[email protected]>

* Revert "Remove version tags and add notes for schema changes"

This reverts commit 1622f24.

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: hye-on <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Co-authored-by: Thomas Farr <[email protected]>

* Added paginationDepth to HybridQuery (#848)

* Added paginationDepth to HybridQuery

Signed-off-by: Wonjae Lee <[email protected]>

* Fixed diff and added test with pagination_depth

Signed-off-by: Wonjae Lee <[email protected]>

* Lint & changelog

Signed-off-by: Wonjae Lee <[email protected]>

---------

Signed-off-by: Wonjae Lee <[email protected]>
Co-authored-by: Thomas Farr <[email protected]>

* Added `warm` to `ClusterNodeCount`

Signed-off-by: Thomas Farr <[email protected]>

* Support indices and shards on nodes stats cache

Signed-off-by: Thomas Farr <[email protected]>

* Add total_primary_shards_per_node

Signed-off-by: Thomas Farr <[email protected]>

* Fix flow framework provision response status code

Signed-off-by: Thomas Farr <[email protected]>

* Fix security status codes

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: hye-on <[email protected]>
Signed-off-by: Wonjae Lee <[email protected]>
Co-authored-by: 조혜온 <[email protected]>
Co-authored-by: Wonjae Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OpenSearch java client does not have pagination_depth in the HybridSearch.Builder
4 participants