Skip to content

feat: Created specs for ltr plugin for stats endpoints #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JohannesDaniel
Copy link
Contributor

Description

Adds API specs for the stats endpoints of the LTR plugin.

Issues Resolved

The PR solves only parts of the subsequent issue to keep its size reasonable.
#786

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Mar 12, 2025

Changes Analysis

Commit SHA: 3d9be01
Comparing To SHA: 28f4510

API Changes

Summary

├─┬Paths
│ ├──[➕] path (4655:3)
│ ├──[➕] path (4638:3)
│ ├──[➕] path (4689:3)
│ └──[➕] path (4673:3)
└─┬Components
  ├──[➕] responses (32079:7)
  ├──[➕] parameters (23813:7)
  ├──[➕] parameters (23827:7)
  ├──[➕] parameters (23803:7)
  ├──[➕] schemas (56569:7)
  ├──[➕] schemas (56525:7)
  ├──[➕] schemas (56558:7)
  ├──[➕] schemas (56512:7)
  ├──[➕] schemas (56534:7)
  └──[➕] schemas (56543:7)

Document Element Total Changes Breaking Changes
components 10 0
paths 4 0
  • Total Changes: 14
  • Additions: 14

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/13815195823/artifacts/2738703945

API Coverage

Before After Δ
Covered (%) 663 (64.94 %) 663 (64.94 %) 0 (0 %)
Uncovered (%) 358 (35.06 %) 358 (35.06 %) 0 (0 %)
Unknown 45 49 4

@JohannesDaniel
Copy link
Contributor Author

can someone help me solving this merge-coverage issue? I have not understood what needs to be done there

@dblock
Copy link
Member

dblock commented Mar 12, 2025

can someone help me solving this merge-coverage issue? I have not understood what needs to be done there

It's saying that tests/plugins/learning_to_rank/ltr/stats.yaml isn't actually used. You actually have to add it to the matrix.

(please do improve the error message!)

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
599 597 (99.67 %)

@nhtruong nhtruong merged commit 74d9e56 into opensearch-project:main Mar 13, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants