Hybrid query should call rewrite before creating weight #1268
Conversation
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
|
@heemin32 @martin-gaievski @navneet1v I found this when I was debugging an issue where changes in core were breaking tests in Hybrid search. We should always be calling rewrite and pass the rewritten value when creating weight |
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
| @@ -117,6 +117,7 @@ public void testQuerySpecs() { | |||
| assertTrue(querySpecs.stream().anyMatch(spec -> HybridQueryBuilder.NAME.equals(spec.getName().getPreferredName()))); | |||
| } | |||
|
|
|||
| @AwaitsFix(bugUrl = "https://github.com/opensearch-project/neural-search/pull/1268") | |||
There was a problem hiding this comment.
I am not entirely sure why this test is failing, will open a new issue
There was a problem hiding this comment.
opensearch-project/OpenSearch#17611. This PR is the reason behind the test failure.
There was a problem hiding this comment.
ah you're right!
There was a problem hiding this comment.
There is an issue with onboarding to the new feature flag framework, see opensearch-project/OpenSearch#17940. For the time being we are skipping this test
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
============================================
- Coverage 81.43% 0 -81.44%
============================================
Files 127 0 -127
Lines 5672 0 -5672
Branches 916 0 -916
============================================
- Hits 4619 0 -4619
+ Misses 698 0 -698
+ Partials 355 0 -355 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
We should always be calling
#rewritebefore we create query weight fromIndexSearcherRelated Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.