-
Notifications
You must be signed in to change notification settings - Fork 165
Fix exposed connector URL in error message #3953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exposed connector URL in error message #3953
Conversation
Signed-off-by: rithin-pullela-aws <[email protected]>
Signed-off-by: rithin-pullela-aws <[email protected]>
Signed-off-by: rithin-pullela-aws <[email protected]>
this exception message is throwing when user try to create a model using the connectors, so we can hide the url to avoid exposing endpoint info to users, but please suggest either update the trusted endpoint in connectors or check the connector url. I think these suggestions would be helpful |
@mingshl, this error is thrown when we try to create the connector. So I believe the error message is good enough. |
I created an issue #3954 to expand this solution to other places where we expose use input. |
then you can suggest to update the trusted endpoint in the cluster setting |
I think based on the input users can decide if they need to add trusted endpoint or not. What if they had some spelling mistake in their url? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3953 +/- ##
============================================
- Coverage 80.61% 80.60% -0.02%
+ Complexity 7945 7943 -2
============================================
Files 694 694
Lines 34872 34872
Branches 3885 3885
============================================
- Hits 28113 28109 -4
- Misses 5032 5033 +1
- Partials 1727 1730 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Fix exposed connector URL in error message Signed-off-by: rithin-pullela-aws <[email protected]> * Fix failing test Signed-off-by: rithin-pullela-aws <[email protected]> * spotless apply Signed-off-by: rithin-pullela-aws <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]> (cherry picked from commit d46a49f)
* Fix exposed connector URL in error message * Fix failing test * spotless apply --------- (cherry picked from commit d46a49f) Signed-off-by: rithin-pullela-aws <[email protected]> Co-authored-by: Rithin Pullela <[email protected]>
* Fix exposed connector URL in error message Signed-off-by: rithin-pullela-aws <[email protected]> * Fix failing test Signed-off-by: rithin-pullela-aws <[email protected]> * spotless apply Signed-off-by: rithin-pullela-aws <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]>
Description
This pull request addresses a security concern where user input, in this case specifically the connector URL was being exposed in error messages. Exposing such information can inadvertently leak sensitive data and does not align with security best practices.
Fix:
Updated the error handling logic to avoid printing the connector URL in error messages, thereby preventing potential information disclosure.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.