Add new additional_config field to model_config and DefaultModelConfig class #3786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig class Signed-off-by: Nathalie Jonathan <[email protected]>
nathaliellenaa
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
Signed-off-by: Nathalie Jonathan <[email protected]>
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
dhrubo-os
reviewed
Apr 28, 2025
common/src/test/java/org/opensearch/ml/common/transport/forward/MLForwardInputTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nathalie Jonathan <[email protected]>
nathaliellenaa
changed the title
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
nathaliellenaa
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
nathaliellenaa
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
nathaliellenaa
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
additional_configfield tomodel_configto store new fields, such asspace_type.DefaultModelConfigclass to handle model configuration for all models, except metrics correlation, question answering, and text embedding model.Related Issues
Resolves #3527
Resolves #3791
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.