[Bug fixes] Fix ListIndexTool and SearchIndexTool

[pyek-bot]

Description

Fixes the description and mapping associated with these tools:

• ListIndexTool
• SearchIndexTool
• IndexMappingTool

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[mingshl]

the next line, the error message will be return to the listener, and it's going to be the same e.getMessage(). is the log needed?

[pyek-bot]

listener behavior might change over time and may not expose these details, so i think its better to explicitly log tool failure here irrespective of listener

[dhrubo-os]

Log is for debugging if later we need to deep dive to identify the root cause. And listener is for customer to be notified at that very moment.

[Zhangxunmt]

how do you know this guarantee that T is actually String. Otherwise this will cause a ClassCastException at runtime.

[ylwu-amzn]

This is existing code. But I think we can enhance the logic as we already know the indexList is empty

[mingshl]

is it the attributes and parameters are reading the same map? what is the intention?

    if (input.readBoolean()) {
        parameters = input.readMap(StreamInput::readString, StreamInput::readOptionalString);
    }
    includeOutputInAgentResponse = input.readBoolean();
    if (input.getVersion().onOrAfter(MINIMAL_SUPPORTED_VERSION_FOR_TOOL_CONFIG) && input.readBoolean()) {
        configMap = input.readMap(StreamInput::readString, StreamInput::readOptionalString);
    }
    this.tenantId = streamInputVersion.onOrAfter(VERSION_2_19_0) ? input.readOptionalString() : null;
    if (input.available() > 0 && input.readBoolean()) {
        attributes = input.readMap(StreamInput::readString, StreamInput::readOptionalString);
    }

[pyek-bot]

earlier, parameters was being overwritten by attributes map as we were reassigning parameters (bug)

now, we are assigning it correctly to attributes

attributes map is the last item in the bytestream, readMap() is a method that allows populating a map from the bytestream

[pyek-bot]

I am noticing some weird behavior in a multi-node cluster, will validate and get back

***resolved, the issue was with reading attributes twice, this code is still valid

[pyek-bot]

PS: 46481bd introduces a new agent type and does not have any test coverage. We plan to release this as an experimental feature. For GA, we will be adding UTs and ITs to cover most scenarios.

This PR fixes a few bugs from the original commit.

[mingshl]

approve to unblock 3.0 beta release. will watch at least one CI pass. Please add IT and UT at 3.0 GA to validate the functionalities

[yuye-aws]

@pyek-bot Can you update the unit tests with attributes on these 3 tools?

[pyek-bot]

@pyek-bot Can you update the unit tests with attributes on these 3 tools?

@yuye-aws Added some basic UT to validate if attributes has input_schema and strict and test their values.
Attributes is primarily used to tell the model what the expected schema is. It replaces a ${parameters.attributes.input_schema} placeholder within a tool template.

This was created in the previous commit: 46481bd

As mentioned in my previous comment, we plan to release this as an experimental feature. For GA, we will be adding UTs and ITs to cover most scenarios including attributes.