add setting to allow private IP

[ylwu-amzn]

Description

We have limited no private IP allowed in connector. Some user want to use private IP. Confirmed with security team, should be fine to have a setting to control allow private IP or not. By default it's disabled, user can enable it by update setting

PUT /_cluster/settings
{
  "persistent": {
    "plugins.ml_commons.connector.private_ip_enabled": true
  }
}

Issues Resolved

Resolve #2142

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[sonic182]

This has been released?

Regards

I saw that yes, in 2.15

[ylwu-amzn]

@sonic182 Yes, this released in 2.5

[hadoopdk]

I tried with 2.15.0 but this still not working:

PUT _cluster/settings
{
"plugins.ml_commons.connector.private_ip_enabled": true
}

error message received:

{
"error": {
"root_cause": [
{
"type": "action_request_validation_exception",
"reason": "Validation Failed: 1: no settings to update;"
}
],
"type": "action_request_validation_exception",
"reason": "Validation Failed: 1: no settings to update;"
},
"status": 400
}

[ylwu-amzn]

@hadoopdk, can you try this

PUT /_cluster/settings
{
  "persistent": {
    "plugins.ml_commons.connector.private_ip_enabled": true
  }
}

[hadoopdk]

@ylwu-amzn , I got this if I run above mentioned statement:

{
"error": {
"root_cause": [
{
"type": "illegal_argument_exception",
"reason": "persistent setting [plugins.ml_commons.connector.private_ip_enabled], not recognized"
}
],
"type": "illegal_argument_exception",
"reason": "persistent setting [plugins.ml_commons.connector.private_ip_enabled], not recognized"
},
"status": 400
}

[opensearch-trigger-bot]

The backport to feature/multi_tenancy failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-feature/multi_tenancy feature/multi_tenancy
# Navigate to the new working tree
cd .worktrees/backport-feature/multi_tenancy
# Create a new branch
git switch --create backport/backport-2534-to-feature/multi_tenancy
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 06d17424d65de18b189b7c259325128b09f3a9ec
# Push it to GitHub
git push --set-upstream origin backport/backport-2534-to-feature/multi_tenancy
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-feature/multi_tenancy

Then, create a pull request where the base branch is feature/multi_tenancy and the compare/head branch is backport/backport-2534-to-feature/multi_tenancy.