[Remote Vector Index Build] fix: end remote build metrics before falling back to CPU, log exceptions #2693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because it is in the
finally
block, the call toendRemoteBuildMetrics
is happening after the fallback strategy so the failure time is inaccurate.Additionally, Exceptions in the remote build process are caught and rethrown to let each step give a failure message:
k-NN/src/main/java/org/opensearch/knn/index/codec/nativeindex/remote/RemoteIndexBuildStrategy.java
Lines 251 to 253 in 76d6662
We should add the exception itself to these debug logs to add more insight into why the failure occurred (for example, adding this to the
submitBuild
step will give the HTTP status code instead of just saying "Submit vector build failed". This is already the case forawaitVectorBuild
.Related Issues
N/A
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.