Skip to content

[Remote Vector Index Build] fix: end remote build metrics before falling back to CPU, log exceptions #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

owenhalpert
Copy link
Contributor

Description

Because it is in the finally block, the call to endRemoteBuildMetrics is happening after the fallback strategy so the failure time is inaccurate.

Additionally, Exceptions in the remote build process are caught and rethrown to let each step give a failure message:

} catch (Exception e) {
log.debug("Repository read failed for vector field [{}]", indexInfo.getFieldName());
throw e;

We should add the exception itself to these debug logs to add more insight into why the failure occurred (for example, adding this to the submitBuild step will give the HTTP status code instead of just saying "Submit vector build failed". This is already the case for awaitVectorBuild.

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owenhalpert owenhalpert changed the title fix: end remote build metrics before falling back to CPU, log exception fix: end remote build metrics before falling back to CPU, log exceptions May 2, 2025
@owenhalpert owenhalpert changed the title fix: end remote build metrics before falling back to CPU, log exceptions [Remote Vector Index Build] fix: end remote build metrics before falling back to CPU, log exceptions May 2, 2025
@navneet1v
Copy link
Collaborator

Can we directly raise pr against 3.0 branch since all CIs are failing

@navneet1v navneet1v added Bug Fixes Changes to a system or product designed to handle a programming bug/glitch backport 3.0 labels May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 3.0 Bug Fixes Changes to a system or product designed to handle a programming bug/glitch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants