Revert CMake version patch, Add CMake policy version flag to build task to support modern CMake builds #2645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenhalpert
changed the title
owenhalpert
force-pushed
the
ubuntu-runner-change
branch
2 times, most recently
from
091c5bf to
133e27f
Compare
owenhalpert
changed the title
owenhalpert
force-pushed
the
ubuntu-runner-change
branch
2 times, most recently
from
1e25b94 to
4c96824
Compare
66 tasks
| @@ -18,7 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| ### Infrastructure | |||
| ### Documentation | |||
| ### Maintenance | |||
| * Update minimum required CMAKE version in NMSLIB [#2635](https://github.com/opensearch-project/k-NN/pull/2635) | |||
There was a problem hiding this comment.
Probably keep the original changelog since you technically just revert the change not remove from tree.
Signed-off-by: owenhalpert <[email protected]>
owenhalpert
force-pushed
the
ubuntu-runner-change
branch
from
4c96824 to
a8b9df3
Compare
Vikasht34
approved these changes
Apr 2, 2025
owenhalpert
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
owenhalpert
changed the title
peterzhuamazon
approved these changes
Apr 2, 2025
1 task
oaganesh
pushed a commit
to oaganesh/k-NN
that referenced
this pull request
Apr 24, 2025
Signed-off-by: owenhalpert <[email protected]>
oaganesh
added a commit
to oaganesh/k-NN
that referenced
this pull request
Apr 29, 2025
This reverts commit 9f49e51.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To address the CMake versioning issue first seen in https://github.com/opensearch-project/k-NN/actions/runs/14176773405/job/39713460988?pr=2615, we created a patch in #2635. This patch caused problems with the
beta1-build, so this is a new way to get CMake to override the minimum version required instead of modifying the source files. This will hopefully fix the beta1 build error (which was because the patch was not compatible) while keeping our KNN CI's intact.Documentation: https://cmake.org/cmake/help/latest/variable/CMAKE_POLICY_VERSION_MINIMUM.html
Related Issues
NA
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.