Clean up flaky tests #247
Merged
Clean up flaky tests #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
added
the
Infrastructure
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
=========================================
Coverage 83.22% 83.22%
Complexity 865 865
=========================================
Files 123 123
Lines 3780 3780
Branches 359 359
=========================================
Hits 3146 3146
Misses 473 473
Partials 161 161 Continue to review full report at Codecov.
|
Shivamdhar
approved these changes
Dec 22, 2021
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: John Mazanec <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Signed-off-by: John Mazanec <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Signed-off-by: John Mazanec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #246 , @martin-gaievski suggested we Ignore as opposed to commenting out for flaky tests. I agree this is a cleaner way of handling flaky test so this PR adds that.
It also fixes one of the commented out tests from training that had been left commented out because the particular functionality was not available when the tests were written.
Lastly, it removes the KNNStats flaky test. This test is too complicated for the value it adds (making sure a counter gets incremented). Therefore, I think it is better just to remove it. We have tested counter functionality in uTs and other iTs.
Issues Resolved
#43
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.