Update values.yaml - Rm whitespace DN

[sebas-intellegens]

Description

According to https://opensearch.org/docs/latest/security-plugin/configuration/security-admin/#configure-the-admin-certificate
there shouldn't be any whitespace in the distinguished name, so I assume it was not correct here?

Issues Resolved

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peterzhuamazon]

Hi @sebas-intellegens please bump the charts version and tick the box for DCO.
Thanks.

[TheAlgo]

@sebas-intellegens Will it be possible for you to fix the conflicts in this PR and if possible create an issue you faced because of this as well. Thanks

[peterzhuamazon]

The DCO check failed please fix it by signing the commit @sebas-intellegens Thanks.

[peterzhuamazon]

Hi @sebas-intellegens please update the version for this PR thanks.

[peterzhuamazon]

@sebas-intellegens seems like you miss the DCO check when pulling from main.
Thanks.

[peterzhuamazon]

@sebas-intellegens seems like you miss the DCO check when pulling from main. Thanks.

Hi @sebas-intellegens can you just git commit --amend --no-edit -s then repush to resolve DCO checks?

Thanks.

[TheAlgo]

LGTM!!!

Reolved Merger conflicts as well 😁

[TheAlgo]

@sebas-intellegens can you please sign off the commit?

[sebas-intellegens]

@sebas-intellegens can you please sign off the commit?

Literally never done this before

No idea how to do this for existing commits
I tried doing this

git commit --amend -s -c c4901e5939d96e3638004ccd12f445330ee654bd
git commit --amend -s -c 89c457a9de8361cbffe15d2788057fb518d0ea43
git commit --amend -s -c f8cf7e58a3af4c583e3d975a6af5bd9c34447bbe

for the commits mentioned here

Hopefully this is what you mean

[peterzhuamazon]

@sebas-intellegens can you please sign off the commit?

Literally never done this before

No idea how to do this for existing commits I tried doing this

git commit --amend -s -c c4901e5939d96e3638004ccd12f445330ee654bd
git commit --amend -s -c 89c457a9de8361cbffe15d2788057fb518d0ea43
git commit --amend -s -c f8cf7e58a3af4c583e3d975a6af5bd9c34447bbe

for the commits mentioned here

Hopefully this is what you mean

git commit --amend --no-edit -s

[sebas-intellegens]

git commit --amend --no-edit -s

Thanks

I ran

git commit --amend --no-edit -s
git pull # Because 'Updates were rejected because the tip of your current branch is behind its remote counterpart.'
git commit --amend --no-edit -s
git push

from my fork
hopefully this worked 🤞

[TheAlgo]

@sebas-intellegens Ouch. That did not work. Can you try amending again?

[sebas-intellegens]

Damn
Now I've tried

git commit --amend -s -c c4901e5939d96e3638004ccd12f445330ee654bd
git commit --amend -s -c 89c457a9de8361cbffe15d2788057fb518d0ea43
git commit --amend -s -c f8cf7e58a3af4c583e3d975a6af5bd9c34447bbe
git pull
git commit --amend --no-edit -s
git push

🤞
Not sure how it is supposed to work, but it doesn't seem to have signed off the initial commits (the ones mentioned here), I was hoping git commit --amend -s -c <HASH> would do that

[DandyDeveloper]

Looks good. I've got the CI running now.

[TheAlgo]

DCO is still failing 😢

[sebas-intellegens]

I created a new branch patch3, made the two changes I made here, committed it with -s, pushed and created a new PR using that branch here #130
Maybe this will work 😄

[TheAlgo]

Closing this PR in favour of #130